fix(DataTable): rowHeight xLarge => xlarge #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
requested review from
alecklandgraf,
hayes,
milesj and
stefhatcher
as code owners
stefhatcher
approved these changes
May 1, 2020
Collaborator
Size Changes
View raw build statsPrevious (master){
"apollo": {
"esm": 10832,
"lib": 14147
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68247,
"lib": 101805
},
"core": {
"esm": 576205,
"lib": 721427
},
"forms": {
"esm": 36180,
"lib": 48408
},
"icons": {
"esm": 156355,
"lib": 205626
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
}Current{
"apollo": {
"esm": 10832,
"lib": 14147
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68247,
"lib": 101805
},
"core": {
"esm": 576326,
"lib": 721548
},
"forms": {
"esm": 36180,
"lib": 48408
},
"icons": {
"esm": 156355,
"lib": 205626
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
} |
williaster
force-pushed
the
chris--datatable-timeout-n-xlarge-ii
branch
from
a7702f5 to
aadb500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @milesj @stefhatcher @hayes @alecklandgraf
Description
This fixes a remaining comment from #367, and updates
xLarge=>xlargefor consistency inDataTablesrowHeightoptions.I tried removing the logic to create a newEDIT: got this to work.timeoutif one existed, just letting the existing one run, but it broke the dynamic updating so I think we should keep it as is.I also added a
clearTimeoutcall on unmount.Motivation and Context
See #367.
Testing
xlargeprop gives correct heightScreenshots
NA
Checklist